enabling overwriting phantomjs binary package_url through an env variable #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
sometimes I get an error on my CI box because bitbucket blocks frequent downloads of the file. This seems to be a common problema (ariya/phantomjs#13951) but it wasn't yet addressed on this gem.
I've added some code to enable overwriting the default package download url with an env variable, just like the people at Medium do - https://github.com/Medium/phantomjs#deciding-where-to-get-phantomjs
What do you think?
(I thought about adding another method that either uses the env variable or delegates to
package_urlbut then it would be a deeper change. Anyway.)