Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1434 from matkoniecz/feature/show_more_interface_elements_by_default #1437

Closed
wants to merge 1 commit into from

Conversation

matkoniecz
Copy link
Contributor

This reverts commit 7ab2ede, reversing changes made to bb7ba04.

…ure/show_more_interface_elements_by_default"

This reverts commit 7ab2ede, reversing
changes made to bb7ba04.
@matkoniecz matkoniecz marked this pull request as draft November 20, 2024 14:22
@matkoniecz
Copy link
Contributor Author

It looks like always showing ThemeSwitcher, SearchBox, DataLayerSwitcher and other switchers is causing problems in tests.

Some of these elements are using fetch. Tests are failing now as these elements are now shown by default.

Note: I will try to fix it rather than merge this, as reverting merge commit results in really weird things.

@matkoniecz
Copy link
Contributor Author

TODO: test which elements causes failure

TODO: try to mock fetch in the test src/frontend/app.test.tsx

@matkoniecz matkoniecz closed this Nov 21, 2024
@matkoniecz matkoniecz deleted the revert_test branch November 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant