Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample historical footprints #1349

Merged

Conversation

mdsimpson42
Copy link
Contributor

Can now toggle between:

  • Historical Map (No Footprints)
  • Historical Map with Modern Footprints
  • Historical Map with Historial Footprints (Sample)

Deploying to Staging for AI UK.

mdsimpson42 and others added 30 commits October 27, 2023 14:06
New bounding box with both London and Loughborough.
Merge upstream, apply postcode attribution
matkoniecz and others added 15 commits February 12, 2024 14:52
ConservationAreaBoundaryLayer on top of buildings, as discussed.
It is disabled by default so can be assumed to be really relevant when enabled.
OSM layer beind buildings, also not coloured ones.
Should now switch betweeen three layers
- Historical Map (no footprints)
- Historical Map (modern footprints)
- Historical Map (historical footprints)

#308
allow rendering tiles over British Isles
@mdsimpson42 mdsimpson42 merged commit dfadb62 into colouring-cities:master Mar 14, 2024
2 checks passed
mdsimpson42 added a commit that referenced this pull request Mar 14, 2024
…prints"

This reverts commit dfadb62, reversing
changes made to f5abdfe.
@matkoniecz
Copy link
Contributor

@mdsimpson42 It looks like you merged UK specific things onto colouring-core like a312c85

@matkoniecz
Copy link
Contributor

I think we should revert it from colouring core and restore earlier version and either apply changes to Colouring Britain or pick up changes relevant in general without bring UK-only parts to Colouring Core.

@mdsimpson42
Copy link
Contributor Author

Yes, I know. I only realised afterwards... I have no idea why it seemed to default to core:master instead of Britain:master. I tried to revert it, but I don't think I got it all? I'm so confused!

@mdsimpson42
Copy link
Contributor Author

I'm not sure if I reverted the right thing. I also think we might need to check branch protection rules.

Will this PR fix it? #1350

@matkoniecz
Copy link
Contributor

Will this PR fix it? #1350

This seems to has only an empty commit?

I would do

git checkout master
git reset --hard f5abdfed
git push --force upstream

note that upstream needs to be changed to whatever name you assigned to https://github.com/colouring-cities/colouring-core.git

@matkoniecz
Copy link
Contributor

f5abdfe is the last commit before this merge and we have no later valuable commits on this branch, hopefully noone else updated their repo

@matkoniecz
Copy link
Contributor

Oh, and git reset --hard f5abdfed may delete in progress work you have that is not committed on a proper branch (and may orphan some commits that will be recoverable with reflog)

@mdsimpson42
Copy link
Contributor Author

Ok, still confused. Do I run these commands in London or Core?

I would do

git checkout master
git reset --hard f5abdfed
git push --force upstream

Also git push --force doesn't work - it asks me to log in and then says Support for password authentication was removed on August 13, 2021.

@mdsimpson42
Copy link
Contributor Author

I'd thought I'd found a way around the authentication, but now its saying the branch is protected and it won't let me do it!

@matkoniecz
Copy link
Contributor

Do I run these commands in London or Core?

For core repository - to get rid of this commits even in history

but now its saying the branch is protected and it won't let me do it!

So either you can change setting to unprotect (its whole point is to block --force pushes) temporarily or I can make megacommit reverting all this changes and open PR.

@mdsimpson42
Copy link
Contributor Author

OK, I think I've got it now. Sorry for the confusion and thanks for the help!

@polly64
Copy link
Contributor

polly64 commented Mar 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants