Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused geometry file. #1320

Merged

Conversation

matkoniecz
Copy link
Contributor

also, it was London-specific anyway.

also, it was London-specific anyway.
@matkoniecz
Copy link
Contributor Author

rg "boundary-detailed.geojson" finds

app/src/frontend/map/layers/city-boundary-layer.tsx
11:        apiGet('/geometries/boundary-detailed.geojson')

rg "boundary.geojson" finds nothing.

Tested in VM with file removed, everything works fine.

@polly64 Do we need this file for anything in core repository? Should it be also removed from Colouring Britain?

Geometries are visualised currently at https://github.com/colouring-cities/colouring-core/blob/master/app/public/geometries/boundary-detailed.geojson (for used file) and https://github.com/colouring-cities/colouring-core/blob/master/app/public/geometries/boundary.geojson (for one being proposed to be removed here)

(spotted while adding display of more geometries for Colouring Britain)

@matkoniecz matkoniecz merged commit 7c313ff into colouring-cities:master Jan 18, 2024
2 checks passed
@matkoniecz matkoniecz deleted the fix/remove_unused_file branch January 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant