Fix: Button: Replace remaining 40px default size violations [Block li…

…brary 1] (WordPress#65033) * Fix legacy comments to use 40px default button size * Fix the embed placeholder button to use 40px default button size * Fix freeform block to use 40px default button size * Fix missing block to use 40px default button size * Revert the instance for modal fullscreen button size This is being reverted because we need to resolve this first - WordPress#65033 (comment) Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
colorful-tones · Sep 6, 2024 · c90f1c5 · c90f1c5
1 parent 95c1995
commit c90f1c5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/packages/block-library/src/comments/edit/comments-legacy.js b/packages/block-library/src/comments/edit/comments-legacy.js
@@ -29,8 +29,7 @@ export default function CommentsLegacy( {
 
 	const actions = [
 		<Button
-			// TODO: Switch to `true` (40px size) if possible
-			__next40pxDefaultSize={ false }
+			__next40pxDefaultSize
 			key="convert"
 			onClick={ () => void setAttributes( { legacy: false } ) }
 			variant="primary"

diff --git a/packages/block-library/src/embed/embed-placeholder.js b/packages/block-library/src/embed/embed-placeholder.js
@@ -66,16 +66,14 @@ const EmbedPlaceholder = ( {
 						justify="flex-start"
 					>
 						<Button
-							// TODO: Switch to `true` (40px size) if possible
-							__next40pxDefaultSize={ false }
+							__next40pxDefaultSize
 							variant="secondary"
 							onClick={ tryAgain }
 						>
 							{ _x( 'Try again', 'button label' ) }
 						</Button>{ ' ' }
 						<Button
-							// TODO: Switch to `true` (40px size) if possible
-							__next40pxDefaultSize={ false }
+							__next40pxDefaultSize
 							variant="secondary"
 							onClick={ fallback }
 						>

diff --git a/packages/block-library/src/freeform/modal.js b/packages/block-library/src/freeform/modal.js
@@ -123,8 +123,7 @@ export default function ModalEdit( props ) {
 					>
 						<FlexItem>
 							<Button
-								// TODO: Switch to `true` (40px size) if possible
-								__next40pxDefaultSize={ false }
+								__next40pxDefaultSize
 								variant="tertiary"
 								onClick={ onClose }
 							>
@@ -133,8 +132,7 @@ export default function ModalEdit( props ) {
 						</FlexItem>
 						<FlexItem>
 							<Button
-								// TODO: Switch to `true` (40px size) if possible
-								__next40pxDefaultSize={ false }
+								__next40pxDefaultSize
 								variant="primary"
 								onClick={ () => {
 									setAttributes( {

diff --git a/packages/block-library/src/missing/edit.js b/packages/block-library/src/missing/edit.js
@@ -50,8 +50,7 @@ export default function MissingEdit( { attributes, clientId } ) {
 
 	const convertToHtmlButton = (
 		<Button
-			// TODO: Switch to `true` (40px size) if possible
-			__next40pxDefaultSize={ false }
+			__next40pxDefaultSize
 			key="convert"
 			onClick={ convertToHTML }
 			variant="primary"