Add format to hsv color space #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hsv color space couldn't be parsed because it didn't have a format entry.
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Thanks! I think we should serialize as --hsv per our recent resolution that nonstandard spaces use dashed idents.
That said, if we have a colorspace with id "--foo" and we are parsing a color with id "foo", it would be nice to parse it correctly and print out a warning (or at least throw a meaningful error). But that's a separate feature.
LeaVerou
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hsv color space couldn't be parsed because it didn't have a format entry.
I wasn't sure if the
idshould behsvor--hsv. Ideally it should be--hsvbut I went withhsvbecause even though you couldn't parse hsv colors they were being serialized ascolor(hsv ...)so the serialization is still backwards compatible.