Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Re-export some types at the top level #327

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

MysteryBlokHed
Copy link
Member

Closes #326

Re-exports some potentially desirable types at the top level instead of requiring them to be manually imported from their individual files.

I basically just went through the files in types/src and added exports in the main index.d.ts file for types and interfaces that might be wanted.

LMK if there are any other types that I missed 😊

Re-exports some potentially desirable types at the top level instead of
requiring them to be manually imported from their individual files.
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional suggestions and one typo, otherwise looks good!

types/index.d.ts Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
MysteryBlokHed and others added 4 commits September 14, 2023 12:14
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
@MysteryBlokHed
Copy link
Member Author

I should be able to update the import tests in a few hours for the new exports since I don’t have access to an IDE right now

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated tests, in case that's helpful.

types/test/type-accessibility.ts Show resolved Hide resolved
types/test/type-accessibility.ts Show resolved Hide resolved
types/test/type-accessibility.ts Show resolved Hide resolved
types/test/type-accessibility.ts Outdated Show resolved Hide resolved
MysteryBlokHed and others added 4 commits September 14, 2023 12:41
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many Typescript types are only accessible by accessing internal files
2 participants