Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our rec2100-hlg is wrong #190

Closed
svgeesus opened this issue Jul 2, 2022 · 4 comments
Closed

Our rec2100-hlg is wrong #190

svgeesus opened this issue Jul 2, 2022 · 4 comments
Labels
bug Something isn't working Topic: Algorithms Issues that relate to the actual color science

Comments

@svgeesus
Copy link
Member

svgeesus commented Jul 2, 2022

I see from the convert app that the results for rec2100-hlg are very wrong.

I thought I knew how to fix it, looking at BT.2390, but I tried it and I don't.

(Note that BT.2390 expects the linear-light intensity range Edash to be 0 to 1 over the HDR range, while our code puts 0-1 over the SDR range so media white is at 1. Even accounting for that, I still couldn't fix it).

It seems from this email that things are more complex than I thought.

Explorations meanwhile are in a separate repo and I want to get some expert review from BBC folks before that comes back to color.js.

In particular there will probably need to be an options object with

  • Lw, the display monitor peak luminance (default 1000)
  • Lb, the display monitor black luminance (default 0.05)
  • Lamb, the ambient luminance (default 5)

to cope with non-reference monitor and non-reference ambient illumination.

Meanwhile here be dragons and don't use our rec2100-hlg for anything important.

@svgeesus svgeesus added bug Something isn't working Topic: Algorithms Issues that relate to the actual color science labels Jul 2, 2022
@LeaVerou
Copy link
Member

LeaVerou commented Jul 2, 2022

You might want to add a note to the JSON that generates our color space docs.

@svgeesus
Copy link
Member Author

svgeesus commented Jul 4, 2022

Note added in f1fa0ed

svgeesus added a commit that referenced this issue Jan 16, 2023
LeaVerou pushed a commit that referenced this issue Jan 16, 2023
@svgeesus
Copy link
Member Author

Now fixed and gives the results expected from ITU-R BT.2390-10 page 25:

Report ITU-R BT.2408 indicates that, for HLG HDR, diffuse white should be set at a signal level of 75%. This can be configured by making the output from an 18% grey card correspond to a signal level of 38%, rather than the 42.5% stated above.

svgeesus added a commit that referenced this issue Jan 16, 2023
@svgeesus
Copy link
Member Author

The scaling factor assumes an overall system gamma of 1, and should be a default which is adjustable for different viewing conditions. For now, it is correct for standard viewing conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Topic: Algorithms Issues that relate to the actual color science
Projects
None yet
Development

No branches or pull requests

2 participants