Circle CI Webhook Upgrade #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmorrison
force-pushed
the
circle-webhook-upgrade
branch
2 times, most recently
from
219e415 to
919169b
Compare
|
Oh, they are building on PRs. Cool. That means I can see what the webhoooks look like… and they look like there's no way to tell they come from a PR. 😒 Circle is not my favorite today. |
danielmorrison
force-pushed
the
circle-webhook-upgrade
branch
from
919169b to
2637f72
Compare
|
I guess I can see the branch name. I guess a quick "fix" is to ignore any branches other than |
danielmorrison
force-pushed
the
circle-webhook-upgrade
branch
from
2637f72 to
822e997
Compare
albus522
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an email today that Circle is sunsetting the
notifyfeature in their config and we need to switch to configuring webhooks via UI or API.This switches that and gets it working.
I apparently don't have this repo hooked up to build on Circle on PRs. We used to filter those out to not affect status. I'm not sure what that looks like anymore, so I need to figure out how to configure that (or nerd snipe @albus522 into it).