-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Rails 6.1 #554
Conversation
former usage is deprecated in Rails >6
@yknx4 Thanks for your contribution! If possible include a description on the PR, and we might also need to add Appraisals support including a # This file was generated by Appraisal
source "https://rubygems.org"
gem "rails", ">= 6.1.0", "< 6.2"
gem "mysql2", ">= 0.4.4", "< 0.6.0"
gem "pg", ">= 0.18", "< 2.0"
gem "sqlite3", "~> 1.4"
gemspec name: "audited", path: "../"
I was also working on this, so feel free to pick these changes from my WIP commit |
@jsantos on it ~ 👍 |
- 6.1 gemfile - new appraisal - readme update - update to travis config Co-authored-by: Jorge Oliveira Santos <jorgeoliveirasantos@gmail.com>
Can any of the maintainers get this merged? I see some builds failing on the CI but these doesn't seem to be consistent... Tried to replicate locally with the same Ruby versions and all was clean. \cc @danielmorrison |
Much appreciate all your hard work. It would be really great if this PR can be merged soon. |
This commit applies changes from collectiveidea#554 to support Rails 6.1.
Any updates on when this is getting merged?? |
Is there anything we can do to help to get this merged? |
At a guess, managing to get all the CI tests to pass might help. Could be a Travis configuration issue as opposed to a problem with the PR changes, but not sure how that gets debugged without being a maintainer. |
Thanks for the work @yknx4! Apologies that I've had zero time to look at this. Thanks to @jmortlok for fixing the build. I merged a few easy things, and i'll cut a release soon. |
Stay up to date with the original gem, including support for Rails 6.1 that was added since the fork. From the changelog: Added - Add redacted option [collectiveidea#485](collectiveidea#485) - Rails 6.1. support [collectiveidea#554](collectiveidea#554) [collectiveidea#559](collectiveidea#559) Improved - Avoid extra query on first audit version [collectiveidea#513](collectiveidea#513)
Required changes to support Rails 6.1