Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plone/meta #7

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Implement plone/meta #7

merged 1 commit into from
Dec 5, 2023

Conversation

ericof
Copy link
Member

@ericof ericof commented Dec 5, 2023

Fixes #6

@ericof ericof added the enhancement New feature or request label Dec 5, 2023
@ericof
Copy link
Member Author

ericof commented Dec 5, 2023

@gforcada We need to make an update on plone/meta. It should be possible to override the package name in tox.

https://github.com/plone/meta/blob/main/config/config-package.py#L353

options['package_name'] = self.path.name

This package name is pytest-plone (according to pytest plugin conventions), but imports are always pytest_plone, which creates an issue with coverage reporting.

In here, I manually edited tox.ini

@ericof ericof merged commit a362d9e into main Dec 5, 2023
5 checks passed
@gforcada
Copy link
Member

gforcada commented Dec 5, 2023

Oh, indeed, good catch, let's create an issue for it.

I'm a bit overwhelmed with personal/family things right now unfortunately. But please fix it manually whenever you have other instances and do a PR if you have time for it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use towncrier to manage CHANGES.md
2 participants