Changes to make compatible with OAM #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
djay
commented
Dec 2, 2024
•
djay
commented
- set client.allow["issuer_mismatch"] = True to make more compatible
- this is tested. decided to use for all since it shouldn't make a difference to non OAM?
- add in changes to make work with OAM
- new advanced setting for identity_domain_name which is used as a param and header which OAM needs apparently
- add header
- add extra params
- test against live OAM
|
Ok, this has now been tested and works against OAM |
mamico
reviewed
Jan 12, 2025
| ) | ||
| else: | ||
| client = Client(client_authn_method=CLIENT_AUTHN_METHOD) | ||
| client.allow["issuer_mismatch"] = ( |
There was a problem hiding this comment.
Yes! I noticed the same issue with the Microsoft implementation. However, in my opinion, it might be better to have this in a separate property, even though this plugin already seems to have too many configurations.
There was a problem hiding this comment.
I can put a toggle for it. It's not exactly clear what the implications are if allow mismatch. I guess its less secure? Could have a toggle that defaults mismatch allowed so it's less likely to trip up first timers?
mamico
approved these changes
Jan 12, 2025
|
@mamico ideally I'd test with more than one OAM but I only have access to one :( But at least I can say that works. |
|
@djay do you need a pypi release ? |
|
@mamico no rush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.