Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more DDI status.execution types and add action id access method #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support more DDI status.execution types and add action id access method #14

wants to merge 2 commits into from

Conversation

dwretman
Copy link

This PR introduces two small additions to extend the functionality:

  • Support for two new DDI status.execution types. These can be used for more fine-grained feedback to hawkBit.
  • A method to get action id of an Update.

Both changes are unobtrusive but adds functionality important to our workflow.

dwretman added 2 commits May 12, 2023 16:24
@dwretman
hawkbit: Add more DDI status.execution types
95caa81 
The types Download and Downloaded as specified on
eclipse.org/hawkbit/apis/ddi_api/ was added to be abe to provide more
detailed execution feedback.
@dwretman
hawkbit: Add method to get action id of an Update
cbe5724
@dwretman dwretman changed the title Feat/small but important additions Support more DDI status.execution types and add action id access method May 15, 2023
stappersg
stappersg approved these changes May 19, 2023
View reviewed changes
Copy link

@stappersg stappersg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwretman
Copy link
Author

Any chance of getting this merged @gdesmott ?

@gdesmott
Copy link
Contributor

Any chance of getting this merged @gdesmott ?

I'm no longer maintaining this crate as I'm no longer working at Collabora.

Best to ask @sjoerdsimons

@dwretman
Copy link
Author

dwretman commented Oct 3, 2023

Any chance of getting this merged @gdesmott ?

I'm no longer maintaining this crate as I'm no longer working at Collabora.

Best to ask @sjoerdsimons

Is someone still maintaining this @sjoerdsimons?

I am also willing to help out maintaining if that would be interesting to you.

@sjoerdsimons
Copy link
Contributor

Any chance of getting this merged @gdesmott ?

I'm no longer maintaining this crate as I'm no longer working at Collabora.
Best to ask @sjoerdsimons

Is someone still maintaining this @sjoerdsimons?

I am also willing to help out maintaining if that would be interesting to you.

Unfortunately we're not doing work around hawkbit at the moment, hence this not getting any attention recently unfortunately (too many projects :/).. If you want to take over this crate I'd be more then happy to hand it over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stappersg stappersg stappersg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwretman @gdesmott @sjoerdsimons @stappersg