Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken logo link #3974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix broken logo link #3974

wants to merge 2 commits into from

Conversation

kantuni
Copy link

@kantuni kantuni commented Feb 7, 2025

Although it works on GitHub, I'm not sure the relative path will resolve properly on https://deno.land/x/.

Summary by CodeRabbit

  • Documentation
    • Updated the README to reference an externally hosted image, ensuring the logo displays consistently regardless of the viewer's file structure.

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be2a097
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/67b5725de2112600085a18cc
😎 Deploy Preview https://deploy-preview-3974--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks
Copy link
Owner

The Deno README gets autogenerated in a commit hook so this will just get overwritten. An absolute URL would work though.

Copy link

coderabbitai bot commented Feb 19, 2025

Walkthrough

The change updates the image source in the README file for the Zod library within the Deno library. The relative path reference to a local file has been replaced with an absolute URL pointing directly to the GitHub-hosted image. This adjustment ensures that the logo is accessible regardless of the document's local file structure.

Changes

File Change Summary
deno/lib/README.md Updated the image source from a local file (logo.svg) to an absolute URL (https://raw.githubusercontent.com/colinhacks/zod/main/logo.svg).

Poem

I'm a rabbit, hopping with delight,
A small change made the view so bright.
From local paths to a web-hosted light,
The Zod logo now shines with might.
Carrots and code, what a beautiful sight!
Hop on, dear coder, into the night!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e376cda and be2a097.

📒 Files selected for processing (1)
  • deno/lib/README.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • deno/lib/README.md

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kantuni
Copy link
Author

kantuni commented Feb 19, 2025

@colinhacks would you like me to update the main README as well for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants