Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed freezing async ZodReadonly results #3457

Merged
merged 3 commits into from
May 2, 2024
Merged

Fixed freezing async ZodReadonly results #3457

merged 3 commits into from
May 2, 2024

Conversation

zsilbi
Copy link
Contributor

@zsilbi zsilbi commented May 2, 2024 •
edited
Loading

Hello!

I noticed that the parsed results of readonly() schemas are not really readonly after parseAsync()
I added tests, then a fix. (and corrected a minor typo in the related docs)

  • Your code changes are well-documented.
  • You have tested your changes.
  • You have updated any relevant documentation.

@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited
Loading

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d06b4d6
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6633b13b65dd940008e74b37
😎 Deploy Preview https://deploy-preview-3457--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks
Copy link
Owner

colinhacks commented May 2, 2024 •
edited
Loading

Good catch. Thanks!

@colinhacks colinhacks merged commit 04e1f37 into colinhacks:master May 2, 2024
4 checks passed
@colinhacks
Copy link
Owner

Landed in v3.23.6

@JonasLang-dev JonasLang-dev mentioned this pull request May 24, 2024
Open
@b34c0n5 b34c0n5 mentioned this pull request May 24, 2024
Open
@eriklopess eriklopess mentioned this pull request May 24, 2024
Open
@s-laugh s-laugh mentioned this pull request May 24, 2024
Merged
@bilelsalemdev bilelsalemdev mentioned this pull request May 24, 2024
Open
@carltrepanier carltrepanier mentioned this pull request May 24, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@pshaddel pshaddel mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@Eiromplays Eiromplays mentioned this pull request May 25, 2024
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request May 25, 2024
Open
@Hamed-Ebrahimii Hamed-Ebrahimii mentioned this pull request May 25, 2024
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request May 25, 2024
Open
@RedLegendDev RedLegendDev mentioned this pull request May 26, 2024
Open
@sandermendes sandermendes mentioned this pull request May 26, 2024
Open
@THamza THamza mentioned this pull request May 26, 2024
Open
@gemo072 gemo072 mentioned this pull request May 27, 2024
Open
@carltrepanier carltrepanier mentioned this pull request May 28, 2024
Merged
@pshaddel pshaddel mentioned this pull request May 28, 2024
Closed
@b34c0n5 b34c0n5 mentioned this pull request May 28, 2024
Merged
@lryanle lryanle mentioned this pull request May 29, 2024
Open
@Eiromplays Eiromplays mentioned this pull request May 29, 2024
Open
@bilelsalemdev bilelsalemdev mentioned this pull request May 29, 2024
Open
This was referenced Aug 22, 2024
Open
Open
Open
This was referenced Aug 22, 2024
Open
Open
@Niraj-Dilshan Niraj-Dilshan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 29, 2024
Open
Open
Open
@sureshbabubonthu sureshbabubonthu mentioned this pull request Aug 30, 2024
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request Aug 31, 2024
Open
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
@sandeepdsvs sandeepdsvs mentioned this pull request Sep 6, 2024
Closed
@dyetto dyetto mentioned this pull request Sep 6, 2024
Open
@eriklopess eriklopess mentioned this pull request Sep 7, 2024
Open
@Ocor17 Ocor17 mentioned this pull request Sep 9, 2024
Open
@anandanshul anandanshul mentioned this pull request Sep 11, 2024
Open
@JoaoManoelFontes JoaoManoelFontes mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@cibedex cibedex mentioned this pull request Sep 24, 2024
Open
@JonasLang-dev JonasLang-dev mentioned this pull request Sep 24, 2024
Open
@THamza THamza mentioned this pull request Sep 28, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@junjiepro junjiepro mentioned this pull request Oct 2, 2024
Open
@sandeepdsvs sandeepdsvs mentioned this pull request Oct 4, 2024
Open
@tobiaslafleur tobiaslafleur mentioned this pull request Oct 31, 2024
Open
@gabrielborgesdm gabrielborgesdm mentioned this pull request Nov 1, 2024
Open
@iamaffanyasir iamaffanyasir mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsilbi @colinhacks