Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export jsdoc with @deprecated when building #2717

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

amotarao
Copy link
Contributor

@amotarao amotarao commented Sep 7, 2023

I didn't know for a long time that z.string().nonempty() was deprecated.

  • JSdoc was deleted in build:cjs, so prevented it.
  • JSdoc was output in the constructor when arrow functions were used in the class, so prevented it.
  • Fixed comment not in JSdoc format.

before

スクリーンショット 2023-09-07 11 44 55

after

with strike
スクリーンショット 2023-09-07 11 46 12

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 908e2e6
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/64f93fd72edfae0008342687
😎 Deploy Preview https://deploy-preview-2717--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinhacks
Copy link
Owner

Nice, thanks!

@colinhacks colinhacks merged commit 699ccae into colinhacks:master Oct 4, 2023
8 checks passed
@amotarao amotarao deleted the nonempty-deprecated branch October 10, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants