Tests for permissions and more #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucifurtun
reviewed
Jul 29, 2019
| db.connect() | ||
| db.create_tables(MODELS) | ||
| def database(database_maker): | ||
| return database_maker(models=MODELS) |
There was a problem hiding this comment.
Do we need this database_maker to be a fixture?
There was a problem hiding this comment.
Technically speaking, we don't need anything to be fixture-decorated but since that's the recommended pytest way, why not following it?
There was a problem hiding this comment.
I didn't know pytest recommends this way. I actually don't see why we should have a fixture if it's not used as a fixture (for tests).
There was a problem hiding this comment.
On a second (third actually) thought, I think it's best that we keep it as a fixture. Reasons are:
- Its friend,
http_client_maker()follows the same pattern and it must be a fixture so that it receives theaiohttp_clientfixture injection. - We shouldn't force testers to always create an intermediate fixture so that they can use
database_maker. It should be usable directly as a fixture itself, being invoked as a db factory inside the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.