Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useYAt #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: useYAt #82

wants to merge 2 commits into from

Conversation

hannojg
Copy link
Contributor

@hannojg hannojg commented Mar 7, 2022

Why

We might want to render any arbitrary view on the y-axis like the horizontal line. I thus created a useYAt hook so consumers can use that to build anything with it.

I extracted the logic out of the HorizontalLine component, which now uses this hook.

Test plan

Simulator Screen Shot - iPhone 13 Pro - 2022-03-07 at 21 17 06

I made sure that the horizontal line is still rendering as expected with that change.

@arancauchi
Copy link
Collaborator

Thanks so much for this pr :)

I believe there's a conflict preventing it from being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants