Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-361] Modal v2 #522

Merged
merged 9 commits into from
Jan 27, 2023
Merged

[MDS-361] Modal v2 #522

merged 9 commits into from
Jan 27, 2023

Conversation

tkullisaar
Copy link
Contributor

No description provided.

phgrey
phgrey reviewed Jan 24, 2023
View reviewed changes
phgrey
phgrey approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@phgrey phgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. see minor comments

@tkullisaar tkullisaar marked this pull request as ready for review January 24, 2023 20:35
phgrey
phgrey approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@phgrey phgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do really like this component! not sure we have to make it statefful. see one minor question for the slot.
good job!

@tkullisaar tkullisaar merged commit 785fc0f into main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phgrey phgrey phgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkullisaar @phgrey