Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-342] Popover v2 #515

Merged
merged 17 commits into from
Feb 3, 2023
Merged

[MDS-342] Popover v2 #515

merged 17 commits into from
Feb 3, 2023

Conversation

tkullisaar
Copy link
Contributor

No description provided.

@tkullisaar tkullisaar marked this pull request as draft January 19, 2023 21:06
@tkullisaar tkullisaar marked this pull request as ready for review January 31, 2023 13:23
@tkullisaar tkullisaar force-pushed the MDS-342 branch 2 times, most recently from ce95f44 to cbb7814 Compare January 31, 2023 14:55
phgrey
phgrey reviewed Jan 31, 2023
View reviewed changes
phgrey
phgrey reviewed Feb 1, 2023
View reviewed changes
phgrey
phgrey reviewed Feb 1, 2023
View reviewed changes
@phgrey
fixing placement - 1
0780914 
fixing placement & examples structure
phgrey
phgrey reviewed Feb 3, 2023
View reviewed changes
phgrey
phgrey reviewed Feb 3, 2023
View reviewed changes
phgrey
phgrey approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@phgrey phgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments, good job!

@tkullisaar tkullisaar merged commit c170ea4 into main Feb 3, 2023
@tkullisaar tkullisaar deleted the MDS-342 branch February 3, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phgrey phgrey phgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkullisaar @phgrey