Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align name and URL for Colours page #473

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Align name and URL for Colours page #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/moon_web/components/left_menu.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ defmodule MoonWeb.Components.LeftMenu do
<SidebarLink route={Pages.VisionPage}>Vision</SidebarLink>
<SidebarLink route={Pages.GettingStartedPage}>Getting Started</SidebarLink>
<SidebarLink :if={!@hide_items} route={Pages.ContributePage}>How to contribute</SidebarLink>
<SidebarLink route={Pages.ColoursPalettePage}>Colours Palette</SidebarLink>
<SidebarLink route={Pages.ColoursPalettePage}>Colours</SidebarLink>
<SidebarLink route={Pages.TokensPage}>Tokens</SidebarLink>
<SidebarLink route={Pages.ManifestPage}>Manifest</SidebarLink>
<Accordion
Expand Down
6 changes: 3 additions & 3 deletions lib/moon_web/pages/colours_palette_page.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ defmodule MoonWeb.Pages.ColoursPalettePage do
data(breadcrumbs, :any,
default: [
%{
to: "/colours-palette",
name: "Colours Palette"
to: "/colours",
name: "Colours"
}
]
)
Expand Down Expand Up @@ -234,7 +234,7 @@ defmodule MoonWeb.Pages.ColoursPalettePage do
def render(assigns) do
~F"""
<Page {=@theme_name} {=@active_page} {=@breadcrumbs} {=@direction}>
<ComponentPageDescription title="Colours Palette" image="/moon/assets/images/facing/colors.webp">
<ComponentPageDescription title="Colours" image="/moon/assets/images/facing/colors.webp">
<p>Our design system is decentralized and built for multi-product purposes. Having different-color naming conventions and numbers etc... makes it harder to maintain it.</p>
<p>For that, we made a decision to give our colours unique names.</p>
<p>Meet the <span class="font-semibold">Dragon Ball Z approach</span>.</p>
Expand Down
2 changes: 1 addition & 1 deletion lib/moon_web/router.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ defmodule MoonWeb.Router do
live("/vision", MoonWeb.Pages.VisionPage)
live("/getting-started", MoonWeb.Pages.GettingStartedPage)
live("/contribute", MoonWeb.Pages.ContributePage)
live("/colours-palette", MoonWeb.Pages.ColoursPalettePage)
live("/colours", MoonWeb.Pages.ColoursPalettePage)
live("/tokens", MoonWeb.Pages.TokensPage)
live("/assets/age_limit", MoonWeb.Pages.Assets.AgeLimitPage)
live("/assets/crests", MoonWeb.Pages.Assets.CrestsPage)
Expand Down