Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering moon components outside surface templates [MDS-248] #421

Merged
merged 1 commit into from
Nov 4, 2022
Merged

rendering moon components outside surface templates [MDS-248] #421

merged 1 commit into from
Nov 4, 2022

Conversation

phgrey
Copy link
Contributor

@phgrey phgrey commented Oct 21, 2022

added a render helper & a page that explained how to use it
a bit modified PageSection component (for anchors in urls)
a bit modified CodeSnippet for removing extra spaces

@phgrey phgrey force-pushed the MDS-248 branch 5 times, most recently from da77615 to ca615fa Compare October 26, 2022 10:41
theycallmehero
theycallmehero reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@theycallmehero theycallmehero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment.

@theycallmehero
Copy link
Contributor

theycallmehero commented Nov 1, 2022 •
edited
Loading 

rm -rf assets/node_modules 
rm -rf deps 
rm -rf _build
mix deps.get && mix assets.setup

main seems to be working. MDS-248 seems to be broken.

Please use private tab with no cache.

@phgrey phgrey force-pushed the MDS-248 branch 4 times, most recently from b384085 to c4f6fec Compare November 3, 2022 18:04
@theycallmehero theycallmehero merged commit d764da2 into main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theycallmehero theycallmehero theycallmehero approved these changes

@alexisdevtailor alexisdevtailor Awaiting requested review from alexisdevtailor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phgrey @theycallmehero