Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Add stablecoin conversion #347

Merged
merged 5 commits into from
Nov 2, 2018
Merged

Add stablecoin conversion #347

merged 5 commits into from
Nov 2, 2018

Conversation

vansergen
Copy link
Contributor

It adds stablecoin conversion as described here

Copy link
Contributor

@fb55 fb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue, otherwise looks great. Thanks a lot for looking into this!


Promise.all([cbtest, promisetest])
.then(() => done())
.catch(err => assert.ifError(err) || assert.fail);
Copy link
Contributor

@fb55 fb55 Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert.fail is not called

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix it

assert.fail is called
@fb55 fb55 merged commit adfc380 into coinbase:master Nov 2, 2018
@fb55
Copy link
Contributor

fb55 commented Nov 2, 2018

Amazing, thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants