Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

add engines config #32

Merged
merged 1 commit into from
Jun 15, 2017
Merged

add engines config #32

merged 1 commit into from
Jun 15, 2017

Conversation

givanse
Copy link
Contributor

@givanse givanse commented Mar 12, 2017

What Node versions does this npm module support?

I might be wrong, but I'm guessing >= 4. The reason is Node 0.10, 0.11 and 0.12 have reached end-of-life.

@fb55
Copy link
Contributor

fb55 commented Mar 12, 2017

The underlying networking library is request, as long as they support a node version this library should continue to work as well. (Of course newer versions of node are also supported.)

@givanse
Copy link
Contributor Author

givanse commented Mar 13, 2017

https://github.com/request/request/blob/c57fb7258788888e42fcfa2b6d54c8150517cabe/package.json

  "engines": {
    "node": ">= 4"
  },

this is great news, most of ES6 could be used ;)

@awitherow
Copy link
Contributor

Who is in charge of this project? Can this be merged?

This was referenced Apr 6, 2017
@awitherow
Copy link
Contributor

@fb55 any ideas on getting this merged with a higher node verison? Would automagically help a lot of "modernized" failed tests.

@nikulis
Copy link
Contributor

nikulis commented Jun 9, 2017

Of interest would be Node's official LTS schedule.

With 4.x reaching end-of-life in less than a year, and 8.x reaching official LTS even sooner than that, I think that going with any of 6.x - 8.x would be an ok move.

In my own opinion, because I love async/await so much, I would recommend >= 7.6.0.

@fb55 fb55 merged commit 435d874 into coinbase:master Jun 15, 2017
@fb55
Copy link
Contributor

fb55 commented Jun 15, 2017

I merged this to already have a basis for specifying a version. I would like to still support one LTS release, which means we should support node 6. Please let me know if there are any reasons besides async/await* to specify any version higher than 6.0.0.

* I'm also a fan of async/await, but having one battle-tested version of node support this library has precedence for now.

@givanse givanse deleted the node-v branch July 6, 2017 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants