This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Add typings for stop limit orders #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfkiwi
changed the title
|
Thanks! |
|
How often do you bundle releases for package managers. Asking to get an
idea when I can incorporate the follow-on changes into gdax-tt project?
|
|
We don't have a schedule, but we do intent to pick up the pace of releases. |
|
This has been released as 0.7.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to place stop limit orders is not documented as described in issue #164. While it's still possible to place a stop limit when directly interfacing with the gdax-node library it is not possible when using the gdax-tt due to the typescript declaration limitations. I am extending the BaseOrder interface declaration as per the GDAX API Reference. This will enable the necessary changes to be made on the gdax-tt project to also support stop limit orders.