This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Fetch crypto deposit addresses #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
sin4orever
approved these changes
Feb 19, 2018
fb55
reviewed
Feb 20, 2018
lib/clients/authenticated.js
Outdated
| depositCrypto(params, callback) { | ||
| this._requireParams(params, ['currency']) | ||
| return new Promise((resolve, reject) => { | ||
| this.get(['coinbase-accounts']).then((coinbaseAccounts) => { |
lib/clients/authenticated.js
Outdated
| @@ -245,6 +245,17 @@ class AuthenticatedClient extends PublicClient { | |||
| return this.post(['deposits/coinbase-account'], { body: params }, callback); | |||
| } | |||
|
|
|||
| depositCrypto(params, callback) { | |||
| this._requireParams(params, ['currency']) | |||
| return new Promise((resolve, reject) => { | |||
There was a problem hiding this comment.
Why return a new promise here?
passabilities
force-pushed
the
address
branch
from
b566ddd to
4b8f056
Compare
passabilities
force-pushed
the
address
branch
from
4b8f056 to
4dcd030
Compare
|
@fb55 fixed |
fb55
reviewed
Feb 20, 2018
lib/clients/authenticated.js
Outdated
| .then((coinbaseAccounts) => { | ||
| let account = coinbaseAccounts.find(a => a.currency === params.currency); | ||
| return this.post(['coinbase-accounts', account.id, 'addresses'], callback); | ||
| }); |
There was a problem hiding this comment.
Catch errors if there is a callback provided?
fb55
reviewed
Feb 20, 2018
lib/clients/authenticated.js
Outdated
| depositCrypto(params, callback) { | ||
| this._requireParams(params, ['currency']); | ||
| return this.getCoinbaseAccounts() | ||
| .then((coinbaseAccounts) => { |
There was a problem hiding this comment.
Prettier should get rid of these parenthesis
|
Prettier seems to be skipped. Otherwise lgtm! |
|
The formatting is still off. Can you please run prettier on these files? |
passabilities
force-pushed
the
address
branch
from
8a03dff to
094b067
Compare
passabilities
force-pushed
the
address
branch
from
094b067 to
ce35101
Compare
|
Sorry for the pause and thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a hack found by @pcfreak30 and @sagivo in this thread #91