Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

More efficient orderbook sync, emitting 'synced' message upon completion #253

Merged
merged 4 commits into from
Feb 2, 2018

Conversation

ko0f
Copy link
Contributor

@ko0f ko0f commented Jan 30, 2018

No description provided.

@fb55
Copy link
Contributor

fb55 commented Jan 30, 2018

Nice! Would you mind adding a test case for the synced message? Also, if we emit this every time we sync we should probably also add an event for when we decide to sync again.

@ko0f
Copy link
Contributor Author

ko0f commented Jan 31, 2018

There ya go. :)

@fb55 fb55 merged commit 131f015 into coinbase:master Feb 2, 2018
@fb55
Copy link
Contributor

fb55 commented Feb 2, 2018

Amazing, thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants