Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Upgrade and relax dependencies #241

Merged
merged 3 commits into from
Jan 20, 2018
Merged

Upgrade and relax dependencies #241

merged 3 commits into from
Jan 20, 2018

Conversation

rmm5t
Copy link
Contributor

@rmm5t rmm5t commented Jan 20, 2018 •
edited
Loading

What does it do?

  • Upgrades and relaxes core dependencies. Static versions are ill-advised for shared libraries, because clients cannot take advantage of 3rd party bug fixes and performance improvements. Let semver do its thing.
  • Upgrades mocha and nock dev dependencies. This actually exposed an errant test connection in test suite.
  • Closes out the errant websocket server in test suite.

/cc @fb55

Aside, much of #239 (now merged) and #240 (now merged) was discovered while trying to work on this.

@fb55 fb55 merged commit 8943010 into coinbase:master Jan 20, 2018
@fb55
Copy link
Contributor

fb55 commented Jan 20, 2018

Nice, thanks a lot :)

@rmm5t rmm5t deleted the upgrade-and-relax-dependencies branch January 20, 2018 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmm5t @fb55