Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

promise method from sample code doesn't work #153

Closed
markshust opened this issue Dec 2, 2017 · 2 comments
Closed

promise method from sample code doesn't work #153

markshust opened this issue Dec 2, 2017 · 2 comments

Comments

@markshust
Copy link

using the below script:

const Gdax = require('gdax');
const publicClient = new Gdax.PublicClient();

publicClient
  .getProducts()
  .then(data => {
    console.log('data', data);
    // work with data
  })
  .catch(error => {
    console.log('error', error);
    // handle the error
  });

expected: data and error logged to console
actual:

./node_modules/gdax/lib/clients/public.js:57
      throw "Must supply a callback."
      ^
@markshust
Copy link
Author

It appears the npm version of the module is out of date. i'm assuming this is not auto-published, so recommending to add a note to the readme about which version to use, as i was really wondering why the code wasn't working.

@rmm5t
Copy link
Contributor

rmm5t commented Dec 28, 2017

@markoshust Would you mind closing this issue in favor of consolidating the discussion under #148? There's a deeper discussion going on there.

@fb55 fb55 closed this as completed Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants