Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for spilling #229

Merged
merged 14 commits into from
Aug 18, 2022
Merged

Integration tests for spilling #229

merged 14 commits into from
Aug 18, 2022

Conversation

hendrikmakait
Copy link
Member

Closes #136

Comment on lines +39 to +40
"DASK_DISTRIBUTED__WORKER__CONNECTIONS__INCOMING": "1",
"DASK_DISTRIBUTED__WORKER__CONNECTIONS__OUTGOING": "1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to reduce the number of incoming and outgoing connections to avoid getting the worker oom-killed. With a default chunk size of 100 MiB from the dask.array, having 4 incoming and 4 outgoing connections at the same time means that we might use up to 800 MiB for communications. With the (previous) default of a t3.medium machine, this appears to be ~25 % of the actual memory that we can use. Together with the misconfigured Worker.memory_limit (coiled/feedback#185), we reliably trigger the oom-killer when running the workload without the adjusted config. See dask/distributed#6208 for an existing upstream issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hendrikmakait is this safe to remove now that coiled/feedback#185 is resolved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is an ongoing effort in dask/distributed#6208 to resolve the underlying issue. coiled/feedback#185 made this even worse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think we may need to skip this test for a while until this is a bit more stable (cf #280 )

@fjetter fjetter merged commit 82d6b21 into main Aug 18, 2022
@ian-r-rose
Copy link
Contributor

Thanks @hendrikmakait!

@fjetter fjetter deleted the spilling-tests branch August 23, 2022 06:52
@fjetter fjetter mentioned this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests: spill/unspill
3 participants