Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client.wait_for_workers instead of wait_for_workers kwarg #1571

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Use client.wait_for_workers instead of wait_for_workers kwarg #1571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/geospatial/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def _(n_workers, env=None, **cluster_kwargs):
if env:
cluster.send_private_envs(env=env)
with cluster.get_client() as client:
# FIXME https://github.com/coiled/platform/issues/103
client.wait_for_workers(n_workers)
with benchmark_all(client):
yield client

Expand Down
1 change: 0 additions & 1 deletion tests/geospatial/test_atmospheric_circulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def test_atmospheric_circulation(
cluster_kwargs={
"workspace": "dask-benchmarks-gcp",
"region": "us-central1",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down
2 changes: 0 additions & 2 deletions tests/geospatial/test_climatology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def test_rechunk_map_blocks(
cluster_kwargs={
"workspace": "dask-benchmarks-gcp",
"region": "us-central1",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down Expand Up @@ -143,7 +142,6 @@ def test_highlevel_api(
cluster_kwargs={
"workspace": "dask-benchmarks-gcp",
"region": "us-central1",
"wait_for_workers": True,
"idle_timeout": "1h",
},
scale_kwargs={
Expand Down
1 change: 0 additions & 1 deletion tests/geospatial/test_cloud_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def test_cloud_optimize(
cluster_kwargs={
"workspace": "dask-benchmarks",
"region": "us-west-2",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down
1 change: 0 additions & 1 deletion tests/geospatial/test_rechunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def test_era5_rechunking(
cluster_kwargs={
"workspace": "dask-benchmarks-gcp",
"region": "us-central1",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down
1 change: 0 additions & 1 deletion tests/geospatial/test_satellite_filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def test_satellite_filtering(
cluster_kwargs={
"workspace": "dask-benchmarks-azure",
"region": "westeurope",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down
1 change: 0 additions & 1 deletion tests/geospatial/test_zonal_average.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def test_nwm(
cluster_kwargs={
"workspace": "dask-benchmarks",
"region": "us-east-1",
"wait_for_workers": True,
},
scale_kwargs={
"small": {"n_workers": 10},
Expand Down
Loading