Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect scheduler memray profiles when benchmarking geospatial tests #1568

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Collect scheduler memray profiles when benchmarking geospatial tests #1568

merged 6 commits into from
Oct 24, 2024

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Oct 23, 2024 •
edited
Loading

Closes #1567

Note: This requires tests to be run with the --benchmark flag

@hendrikmakait hendrikmakait mentioned this pull request Oct 23, 2024
Merged
phofl
phofl approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane to me, did you test things?

@hendrikmakait
Copy link
Member Author

This looks sane to me, did you test things?

I tested it locally (which led to #1570 and #1571).

@phofl
Copy link
Contributor

phofl commented Oct 24, 2024

Great!

@phofl phofl merged commit 2f9350c into main Oct 24, 2024
5 checks passed
@phofl phofl deleted the memray-scheduler-profiles branch October 24, 2024 09:39
@phofl
Copy link
Contributor

phofl commented Oct 24, 2024

thanks

@hendrikmakait hendrikmakait self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

@fjetter fjetter Awaiting requested review from fjetter

Assignees

@hendrikmakait hendrikmakait

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect Memray profiles on scheduler for geospatial benchmarks
2 participants
@hendrikmakait @phofl