Skip to content

Commit

Permalink
adjust
Browse files Browse the repository at this point in the history
  • Loading branch information
hendrikmakait committed Aug 6, 2024
1 parent 6745a0e commit 26661b0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 31 deletions.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@
dask:
dataframe:
query-planning: True

array:
rechunk:
method: "p2p"
31 changes: 0 additions & 31 deletions tests/benchmarks/test_rechunk.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,36 +5,9 @@
import pytest
from dask.utils import parse_bytes

from ..conftest import requires_p2p_memory, requires_p2p_rechunk
from ..utils_test import cluster_memory, scaled_array_shape, wait


@pytest.fixture(
params=[
pytest.param("tasks", marks=pytest.mark.shuffle_tasks),
pytest.param("p2p-disk", marks=[pytest.mark.shuffle_p2p, requires_p2p_rechunk]),
pytest.param(
"p2p-memory", marks=[pytest.mark.shuffle_p2p, requires_p2p_memory]
),
]
)
def configure_rechunking(request, memory_multiplier):
if request.param == "tasks":
with dask.config.set({"array.rechunk.method": "tasks"}):
yield
else:
disk = "disk" in request.param
if not disk and memory_multiplier > 0.67:
pytest.skip("Out of memory")
with dask.config.set(
{
"array.rechunk.method": "p2p",
"distributed.p2p.disk": disk,
}
):
yield


@pytest.fixture(params=["8 MiB", "128 MiB"])
def configure_chunksize(request, memory_multiplier):
if memory_multiplier > 0.4 and parse_bytes(request.param) < parse_bytes("64 MiB"):
Expand All @@ -48,7 +21,6 @@ def test_tiles_to_rows(
# Order matters: don't initialize client when skipping test
memory_multiplier,
configure_chunksize,
configure_rechunking,
small_client,
):
"""2D array sliced into square tiles becomes sliced by columns.
Expand All @@ -67,7 +39,6 @@ def test_swap_axes(
# Order matters: don't initialize client when skipping test
memory_multiplier,
configure_chunksize,
configure_rechunking,
small_client,
):
"""2D array sliced by columns becomes sliced by rows.
Expand All @@ -86,7 +57,6 @@ def test_adjacent_groups(
# Order matters: don't initialize client when skipping test
memory_multiplier,
configure_chunksize,
configure_rechunking,
small_client,
):
"""M-to-N use case, where each input task feeds into a localized but substantial
Expand All @@ -103,7 +73,6 @@ def test_adjacent_groups(
def test_heal_oversplit(
# Order matters: don't initialize client when skipping test
memory_multiplier,
configure_rechunking,
small_client,
):
"""rechunk() is used to heal a situation where chunks are too small.
Expand Down

0 comments on commit 26661b0

Please sign in to comment.