-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CircleCI continuous integration #19
Conversation
@awm33 our builds are currently failing -- see https://circleci.com/gh/cognoma/cognoml. How do you suggest we proceed? |
@jessept @vasudevanv -- you may also want to look at why our builds are failing. It may have something to do with our |
@dhimmel @awm33 @vasudevanv it looks like the circleCI is trying to install using python 2.7. I'm guessing this is the default python. From circleCI site under setup.py: python setup.py install |
So should we merge this PR to fix that? |
@dhimmel Yes, I will squash merge this PR. I am going to merge and anticipate seeing another issue for our testing but I want to see if it actually occurs. |
Related to scikit-learn/scikit-learn#4164 (comment)? |
@dhimmel it looks like this is a longstanding issue with conflicting virtual environments. I was able to replicate the issue on my local machine. I get the same missing numpy issue when I try to run File "/Users/jesseprestwood-taylor/miniconda3/lib/python3.5/site-packages/setuptools-20.3-py3.5.egg/setuptools/sandbox.py", line 46, in _execfile However, when I activate my virtual environment, I am able to install with no problem: |
@dhimmel yes it looks related to that. We may have to add numpy explicitly to the virtualenv setup. |
I have had to do this in the past with CircleCI. I used a requirements.txt file with all the dependencies in the virtualenv setup. You will need to add the following to the circle.yml file dependencies: |
@vasudevanv, nice. Want to submit that pull request to add: dependencies:
pre:
- "pip install --requirement requirements.txt" |
Sure. Will submit it shortly. |
The goal of this PR is to have CircleCI automatically run the tests we're implementing in #4, #14, & #17.