Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-21722] ⛏Remove typer dependency from command package #639

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jun 13, 2024

Description

Motivation:

  • Makes it easier to test the commands as typer.context does not have to be mocked.
  • Makes it clearer what the .execute method are using.
  • Do not setup sentry when cognite_toolkit._cdf_tk._cdf.py is not imported, for example, in the https://github.com/cognitedata/maia project a lot of unnecessary sentry errors were triggered as a result of using the commands.

Checklist

Copy link

github-actions bot commented Jun 13, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7288 5678 78% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf.py 55% 🟢
cognite_toolkit/_cdf_tk/commands/auth.py 61% 🟢
cognite_toolkit/_cdf_tk/commands/clean.py 75% 🟢
cognite_toolkit/_cdf_tk/commands/deploy.py 82% 🟢
TOTAL 68% 🟢

updated for commit: cf76c14 by action🐍

@doctrino doctrino merged commit c3ee754 into main Jun 14, 2024
8 checks passed
@doctrino doctrino deleted the remove-typer-dependency branch June 14, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants