Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-21480] 🏂Better build message #627

Merged
merged 9 commits into from
Jun 10, 2024
Merged

[CDF-21480] 🏂Better build message #627

merged 9 commits into from
Jun 10, 2024

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jun 9, 2024

Description

If not source modules are found:
image

And instead of the following when running the cdf-tk build
image

with this one
image

Checklist

Copy link

github-actions bot commented Jun 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7229 5620 78% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/build.py 87% 🟢
cognite_toolkit/_cdf_tk/exceptions.py 80% 🟢
TOTAL 83% 🟢

updated for commit: a003138 by action🐍

@doctrino doctrino changed the title Better build message [CDF-21480] 🏂Better build message Jun 9, 2024
@doctrino doctrino marked this pull request as ready for review June 9, 2024 08:13
@doctrino doctrino requested a review from a team as a code owner June 9, 2024 08:13
Copy link
Collaborator

@ronpal ronpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too crazy about the icons, if we introduce them here I'd like to use the same "style" everywhere. Also, rich has a Tree() class that I'm using in the interactive init, maybe you can use that to get the "folder tree" look?

Co-authored-by: Pål Rønning <ronpal@users.noreply.github.com>
Co-authored-by: Pål Rønning <ronpal@users.noreply.github.com>
@doctrino doctrino merged commit 19f9c33 into main Jun 10, 2024
8 checks passed
@doctrino doctrino deleted the better-build-message branch June 10, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants