Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-21721] 😰Iterate modules bug #625

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[CDF-21721] 😰Iterate modules bug #625

merged 3 commits into from
Jun 10, 2024

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jun 9, 2024

Description

Currently when you call cdf-tk build cognite_toolkit the iterate_modules function searches all directories for modules,
including the code directories _cdf-tk and _api. Instead of just cognite_modules, custom_modules and modules. This goes wrong if you have a project with the modules folder on the root level as then .github folder is considered a module as it contains workflows subdirectory.

Checklist

Copy link

github-actions bot commented Jun 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7218 5614 78% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/utils.py 75% 🟢
TOTAL 75% 🟢

updated for commit: bdc4da2 by action🐍

Copy link
Collaborator

@ronpal ronpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@doctrino doctrino merged commit 92e0e0d into main Jun 10, 2024
8 checks passed
@doctrino doctrino deleted the iterate-modules-bug branch June 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants