[CDF-21573] ♨ Raise on Location #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
commented
Jun 8, 2024
Comment on lines
-158
to
-163
| if ToolGlobals.failed: | ||
| if results and results.has_counts: | ||
| print(results.counts_table()) | ||
| if results and results.has_uploads: | ||
| print(results.uploads_table()) | ||
| raise ToolkitDeployResourceError(f"Failure to load/deploy {loader_instance.display_name} as expected.") |
There was a problem hiding this comment.
This is no longer necessary as we know raise an appropriate exception in the place the error occurred, instead of the generic one here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist
_version.py and
pyproject.toml per semantic versioning.