[CDF-23957] 🧐 Robustify hash calculation #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Feb 5, 2025
| if isinstance(content, str): | ||
| byte_content = content.encode("utf-8") | ||
| else: | ||
| byte_content = content.read_bytes() |
There was a problem hiding this comment.
It is much safer to just hash the bytes directly and not care about the encoding of the file only the hash. Encoding can lead to UnicodeDecodeError
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ronpal
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist
[CDF-12345].