Update tutorial cdm extension via selection of concepts #1035
+2,906
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
reviewed
Mar 4, 2025
| @@ -80,3 +96,83 @@ def data_model(self, concepts: str | list[str]) -> IssueList: | |||
| print(f"Subset to {after} concepts.") | |||
|
|
|||
| return issues | |||
|
|
|||
| def core_data_model(self, concepts: str | list[str]) -> IssueList: | |||
There was a problem hiding this comment.
What is the thinking about placing this method here and not under neat.read.cdf.data_model.cognite_core()? Feels strange to start a session with neat.subset.
There was a problem hiding this comment.
Will move under read...
| @@ -1795,6 +1797,76 @@ def _convert_metadata_to_info(cls, metadata: DMSMetadata) -> "InformationMetadat | |||
| ) | |||
|
|
|||
|
|
|||
| class _SubsetEditableCDMRules(VerifiedRulesTransformer[DMSRules, DMSRules]): | |||
There was a problem hiding this comment.
Why not subclass SubsetDMSRules and add a few extra validations?
For example,
class _SubsetEditableCDMRules(SubsetDMSRules):
if not_in_cognite_core := {view.external_id for view in views} - COGNITE_CORE_CONCEPTS.union(
COGNITE_CORE_FEATURES
):
raise NeatValueError(
f"Concept(s) {', '.join(not_in_cognite_core)} is/are not part of the Cognite Core Data Model. Aborting."
)
super().__init__(views)and similar for the transform method.
There was a problem hiding this comment.
As two classes differ from each other. I am not dropping any of CDM views, to make sure that data model functions in UI. Though I will see if I can subclass it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved Extending Core Data Model tutorial, and made modification to the code base to assure fully functional data model in CDF.
Bump
Changelog
Added
...subset.data_model.core_data_modelinNeatSessionChanged