This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
fix(package.json#browser) #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caps were missing because the files do not provide thickness for closed general cylinders. The thickness is the same as the radius in this case. In addition, there is only one radius provided, but we expected two. (cherry picked from commit 865ebc0)
* RJ3D-460: Normalize angles (#95) * Move normalizeRadians() to new file MathUtils. Add test. * RJ3D-460: Fixed issue causing cones with start angle > PI to be rendered incorrectly. * RJ3D-460: Normalize angles for GeneralRing and GeneralCylinder * Bump version to 0.13.4
* Bump three to 0.110.0 and fix test to use THREE.Matrix4 * [RJ3D-492] Copy normals to avoid shared mutable access Somewhere later in the code, some geometry decides to flip their normal and thus flips the normal for a lot of other geometries...
And add a warning if the treeIndex is still missing from the map.
andeplane
approved these changes
May 13, 2022
maksnester
approved these changes
May 16, 2022
larsmoa
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a bunch of other changes that were never merged to master. See https://cognitedata.slack.com/archives/C6KNJCEEA/p1652440843600499 for context
The only change I made is in a0cd6d6
This fixes the bug that I described here vitejs/vite#8141