Use RIO_TILER_MAX_THREADS instead of MAX_THREADS #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoalmeida94
force-pushed
the
rio-tiles-max-threads
branch
from
1e2912b
to
23c9960
Compare
vincentsarago
requested changes
Oct 7, 2021
There was a problem hiding this comment.
@rodrigoalmeida94 can you update https://github.com/cogeotiff/rio-tiler/blob/fe8c05dbff747aaebedbb223d14294cdf105f069/docs/mosaic.md#more-on-threading and also add a note in the changelog?
rio-tiler-v3 here, I'm not sure if this will cause you trouble. if yes, we'll just merge and open another PR
it would
rodrigoalmeida94
force-pushed
the
rio-tiles-max-threads
branch
from
23c9960
to
c9f4c55
Compare
vincentsarago
approved these changes
Oct 8, 2021
vincentsarago
added a commit
that referenced
this pull request
Oct 19, 2021
* switch to morecantile3 (#418) * switch to morecantile3 * remove python 3.6 * make sure to use rio-cogeo2.3.1 in tests * 🤦 * use rio-cogeo from github * update fixtures and tests * update changelog * deprecate metadata methods (#425) * zxy -> xyz in SpatialMixin.tile_exits method (#419) * No max size (#422) * remove default max_size for part and feature * ignore type, failing in python 3.9 * use rio-cogeo alpha * Use RIO_TILER_MAX_THREADS instead of MAX_THREADS (#432) * MAX_THREADS to RIO_TILER_MAX_THREADS * Update env variable in docs * Add to changelog * Update CHANGES.md Co-authored-by: Vincent Sarago <vincent.sarago@gmail.com> * allow non-earth dataset (#429) * allow non-earth dataset * fix stac * metadata/info returns `geographic_bounds` * add test for non earth object tile reading * add notebook * update changelog * update docs * update * revert and remove min/max zoom in __init__ * edit changes * Use httpx (#431) * Replace requests with httpx * Use httpx instead of requests * Use httpx in notebooks * Add tox to dev requirements * Revert change and remove unused import * update changelog Co-authored-by: Vincent Sarago <vincent.sarago@gmail.com> * add new statistics methods and band names in ImageData object (#427) * add new statistics methods and band names in ImageData object * update base classes and tests * MultiBandReader.statistics should use self.preview as COGReader * update tests * start migration docs * update docs * remove `band_expression` option in MultiBandReader (#437) * Asset expression indexes (#438) * change asset_expression type and add asset_indexes * update changelog * moar docs * Allow float tile_buffer (#405) * Add tests of the expected behaviour * Add `tile_buffer` `float` support in `COGReader.tile()` * :facepalm Co-authored-by: Bernhard Stadlbauer <bstadlbauer@blackshark.ai> Co-authored-by: vincentsarago <vincent.sarago@gmail.com> * update docs and allow backward compat for indexes in MultiBaseReader * Range colormap (#439) * add range colormap support * update docs * update types * s/range/intervals/g * remove deprecated code and update docs (#440) * remove deprecated code and update docs * update changelog Co-authored-by: Rodrigo Almeida <rodrigo@developmentseed.org> Co-authored-by: bstadlbauer <11799671+bstadlbauer@users.noreply.github.com> Co-authored-by: Bernhard Stadlbauer <bstadlbauer@blackshark.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #349
Avoids potential usage of generic MAX_THREADS env variable by other libraries.