make sure we return uint8 when applying colormap #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Sep 14, 2021
rio_tiler/colormap.py
Outdated
| @@ -141,7 +141,7 @@ def apply_discrete_cmap( | |||
| for k, v in colormap.items(): | |||
| res[data[0] == k] = v | |||
|
|
|||
| data = numpy.transpose(res, [2, 0, 1]) | |||
| data = numpy.transpose(res, [2, 0, 1]).astype("uint8") | |||
There was a problem hiding this comment.
we make sure the output is in uint8
vincentsarago
commented
Sep 14, 2021
| InvalidDatatypeWarning, | ||
| ) | ||
| data = self._rescale(data, self.mask, in_range=datatype_range) | ||
| if not colormap: |
There was a problem hiding this comment.
if there is a colormap passed we don't need to auto-rescale
|
test are failing because of recent change in rasterio (see: rasterio/rasterio#2289) but was fixed in #418 by changing the dateline dataset let me see if I can bring the change we push in rio-tiler-v3 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #421