-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass options to the fetch function #404
Conversation
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
Not a strong opinion, but it feels weird to me that A user might pass a boto3 session kwarg and expect it be passed to client but it won't (assuming they aren't passing the client directly). If its really just s3 requester pays that we want to expose I think it makes more sense to have a single boolean argument ( |
Ok let me try something else! |
…into clientOptions
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
Sorry for the missed review. Thank you for the effort! |
closes #397
@emmanuelmathot can you check this :-)