Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass options to the fetch function #404

Merged
merged 7 commits into from
Jul 28, 2021
Merged

pass options to the fetch function #404

merged 7 commits into from
Jul 28, 2021

Conversation

vincentsarago
Copy link
Member

closes #397

@emmanuelmathot can you check this :-)

CHANGES.md Outdated Show resolved Hide resolved
rio_tiler/io/stac.py Outdated Show resolved Hide resolved
rio_tiler/io/stac.py Outdated Show resolved Hide resolved
rio_tiler/io/stac.py Outdated Show resolved Hide resolved
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
@geospatial-jeff
Copy link
Member

geospatial-jeff commented Jul 16, 2021

Not a strong opinion, but it feels weird to me that fetch_options wraps both requests and boto3 kwargs but only specific keys from fetch_options are forwarded to boto3 while all keys go to requests. I think this could cause some confusion.

A user might pass a boto3 session kwarg and expect it be passed to client but it won't (assuming they aren't passing the client directly). If its really just s3 requester pays that we want to expose I think it makes more sense to have a single boolean argument (s3_requester_pays) and leave fetch_options just for requests (and maybe rename it to requests_http_kwargs or something more explicit)

@vincentsarago
Copy link
Member Author

Ok let me try something else!

CHANGES.md Outdated Show resolved Hide resolved
@vincentsarago vincentsarago merged commit 26d4733 into master Jul 28, 2021
@vincentsarago vincentsarago deleted the clientOptions branch July 28, 2021 14:26
@emmanuelmathot
Copy link
Contributor

Sorry for the missed review. Thank you for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Authorization manager
4 participants