Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed to package data #363

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Conversation

kylebarron
Copy link
Member

I'm trying to understand the mypy ecosystem better. In the original PEP 561, it references a simple script to check if your package correctly exposes types, and that alleges that rio-tiler isn't exporting types because py.typed isn't included in the distributed output. In the Mypy documentation, it instructs you to include py.typed manually in your package data output.

That said, in an example script that just imports rio_tiler, running mypy test.py doesn't complain about being unable to follow the rio-tiler import, so I can't tell if this is necessary.

@vincentsarago vincentsarago self-requested a review March 16, 2021 20:39
@vincentsarago vincentsarago merged commit 2a0b308 into master Mar 18, 2021
@vincentsarago vincentsarago deleted the kyle/add-py.typed-package-data branch March 18, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants