add parse_color function #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatial-jeff
approved these changes
Mar 5, 2021
kylebarron
reviewed
Mar 7, 2021
kylebarron
reviewed
Mar 7, 2021
rio_tiler/colormap.py
Outdated
|
|
||
| """ | ||
| if isinstance(value, str): | ||
| if re.match("^#[a-fA-F0-9]{3,4}$", value): |
There was a problem hiding this comment.
IMO a regex is overkill here. You can just assert that the string starts with # (if you want) and then if the string has <=4 more characters, you treat it as the first type, otherwise the second. And if an error is created that gets propagated to the user. But not a strong preference.
There was a problem hiding this comment.
FYI, that's how matplotlib does: https://github.com/matplotlib/matplotlib/blob/fa73bc09d62aef99842bbbd13dca687ac5bbd0b9/lib/matplotlib/colors.py#L237-L265
I think overkill regex are fine :-)
kylebarron
approved these changes
Mar 7, 2021
vincentsarago
commented
Mar 8, 2021
| if len(rgba) == 3: | ||
| rgba += (255,) | ||
|
|
||
| return rgba # type: ignore |
There was a problem hiding this comment.
I couldn't keep mypy happy here because it lost the track on the number of items in rgba 🤷♂️
geospatial-jeff
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref developmentseed/titiler#262
This PR adds a function to parse colormap value from HEX for list.