asyncio support #265
asyncio support #265
Conversation
rio_tiler/io/base.py
Outdated
| @@ -92,6 +83,95 @@ def point(self, lon: float, lat: float, **kwargs: Any) -> List: | |||
| ... | |||
|
|
|||
|
|
|||
| @attr.s | |||
| class AsyncBaseReader(metaclass=abc.ABCMeta): | |||
There was a problem hiding this comment.
abc doesn't enforce the signature of the method, just that the method is present, so we could reuse the base class but mypy is not happy because the response types are different.
There was a problem hiding this comment.
So we just need to make sure that this base class maintains parity with the BaseReader?
There was a problem hiding this comment.
Yeah, there might be a better way to enforce the same type across both classes besides duck typing but I can't think of one that would make mypy happy.
|
I'd like to try this out in aiocogeo before we merge. Started that work in a branch (https://github.com/geospatial-jeff/aiocogeo/tree/rio-tiler) but there are a few things I need to add first to match rio-tiler like color interp and color table. |
geospatial-jeff
force-pushed
the
async
branch
2 times, most recently
from
af7e44a
to
6afeb3b
Compare
geospatial-jeff
force-pushed
the
async
branch
from
4be7042
to
2d52c87
Compare
geospatial-jeff
force-pushed
the
async
branch
from
e40aa0d
to
333dc1a
Compare
rio_tiler/io/base.py
Outdated
| @@ -92,6 +83,95 @@ def point(self, lon: float, lat: float, **kwargs: Any) -> List: | |||
| ... | |||
|
|
|||
|
|
|||
| @attr.s | |||
| class AsyncBaseReader(metaclass=abc.ABCMeta): | |||
There was a problem hiding this comment.
So we just need to make sure that this base class maintains parity with the BaseReader?
Closes #264 @vincentsarago @kylebarron