Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Profile page): show join date #586

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat(Profile page): show join date #586

merged 2 commits into from
Dec 18, 2024

Conversation

belong112
Copy link
Contributor

@belong112 belong112 commented Dec 17, 2024 •
edited
Loading

Display join date of a user on their profile page #412

In English
截圖 2024-12-18 上午12 26 06

In Mandarin
截圖 2024-12-18 上午12 27 54

Not sure whether putting JoinDate in that place is optimal for UI

@coveralls
Copy link

Coverage Status

coverage: 71.733%. remained the same
when pulling 284b18a on belong112:feat/show-join-date#412
into 419a0d0 on cofacts:master.

MrOrz
MrOrz approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the contribution!

As for the placement, I think we can merge now and make adjustments if needed

@MrOrz MrOrz merged commit d5a4be4 into cofacts:master Dec 18, 2024
2 checks passed
@belong112 belong112 deleted the feat/show-join-date#412 branch December 19, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belong112 @coveralls @MrOrz