Build config #1
Merged
Build config #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
reviewed
May 11, 2023
| # copy monorepo's build outputs | ||
| # ref: https://github.com/lerna/lerna/issues/2381 | ||
| # | ||
| COPY --from=builder /srv/www/hocuspocus-extension-elasticsearch/dist ./hocuspocus-extension-elasticsearch/dist |
There was a problem hiding this comment.
Note: if we don't add this, then tsc outside will still build hocuspocus-extension-elasticsearch.
However, the directory structure does not match the one written in hocuspocus-extension-elasticsearch's package.json's export key.
…nstructor must be an ArrayBuffer
MrOrz
reviewed
Jun 4, 2023
|
|
||
| export interface ElasticsearchConfiguration extends DatabaseConfiguration { | ||
| elasticsearchOpts?: elasticsearch.ClientOptions; | ||
| db_index?: string; |
There was a problem hiding this comment.
Question: why snake_case here while everywhere else is camelCased?
| const { body: docExist } = await this.db?.exists({ index: 'ydocs', id: documentName, type: 'doc' }) || {} | ||
| // console.log(`DB fetch ${documentName}`); | ||
| const { body: docExist } = | ||
| (await this.db?.exists({ |
There was a problem hiding this comment.
For not exist error, I think we can either check the status code returned by this.db?.get, or try-catch if it throws an error. In this case we don't need an extra exist() call to the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Build elasticsearch extension
Since tsconfig cannot rename output files, we use three different config
tsconfig.cjs.jsontsconfig.esm.jsontsconfig.types.jsonto build different targetDockerfile
hocuspocus-extension-elasticsearch/package.jsonand folderhocuspocus-extension-elasticsearch/distadditionallyRef: Copy local package files to node_modules instead create symlink lerna/lerna#2381
TODO