Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack 5 SingleDependencyEntry error #441

Closed
wants to merge 6 commits into from
Closed

Fix webpack 5 SingleDependencyEntry error #441

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9eb07cd
Fix webpack 5 SingleDependencyEntry error
May 7, 2020
a9dbe4d
Fix webpack 5 SingleDependencyEntry error
May 7, 2020
20f5459
Merge branch 'master' of https://github.com/rahcusa/karma-webpack
May 7, 2020
f936c8b
Fix lint errors
May 7, 2020
77f1f35
Use dynamic require
May 7, 2020
f40e67b
Disable eslint no-dynamic-require
rahcusa May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/karma-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
no-param-reassign,
no-console,
no-shadow,
func-names
func-names,
import/no-dynamic-require
*/

const os = require('os');
Expand All @@ -12,7 +13,12 @@ const cloneDeep = require('clone-deep');
const async = require('neo-async');
const webpack = require('webpack');
const WebpackDevMiddleware = require('webpack-dev-middleware');
const SingleEntryDependency = require('webpack/lib/dependencies/SingleEntryDependency');

const isWebpack4 = webpack.version[0] === '4';
const dependencyPath = isWebpack4 ?
'webpack/lib/dependencies/SingleEntryDependency':
'webpack/lib/dependencies/EntryDependency';
const SingleEntryDependency = require(dependencyPath);

let blocked = [];
let isBlocked = false;
Expand Down Expand Up @@ -300,11 +306,12 @@ Plugin.prototype.make = function(compilation, callback) {

compilation.addEntry('', dep, name, (err) => {
// If the module fails because of an File not found error, remove the test file
const module = isWebpack4 ? dep.module : compilation.moduleGraph.getModule(dep);
if (
dep.module &&
dep.module.error &&
dep.module.error.error &&
dep.module.error.error.code === 'ENOENT'
module &&
module.error &&
module.error.error &&
module.error.error.code === 'ENOENT'
) {
this.files = this.files.filter((f) => file !== f);
invalidate(this.middleware);
Expand Down